LocalAGI port in Go #14
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ettore Di Giacinto <mudler@localai.io>
feat: integrate LocalRAG
Signed-off-by: mudler <mudler@localai.io>
Signed-off-by: Richard Palethorpe <io@richiejp.com>
Signed-off-by: Richard Palethorpe <io@richiejp.com>
Action, connector, MCP, dynamic prompts and anything else that is stored as an array in the config; their fields are always stored as string by the backend. Signed-off-by: Richard Palethorpe <io@richiejp.com>
Contributor
There was a problem hiding this comment.
Copilot reviewed 207 out of 221 changed files in this pull request and generated 1 comment.
Files not reviewed (14)
- .dockerignore: Language not supported
- .env: Language not supported
- .github/workflows/image.yaml: Language not supported
- Dockerfile: Language not supported
- Dockerfile.realtimesst: Language not supported
- Dockerfile.webui: Language not supported
- LICENSE: Language not supported
- Makefile: Language not supported
- config/wizardlm-13b-1.1.yaml: Language not supported
- config/wizardlm-13b-superhot.yaml: Language not supported
- config/wizardlm-13b.yaml: Language not supported
- config/wizardlm-30b-superhot-supercot.yaml: Language not supported
- config/wizardlm-30b.yaml: Language not supported
- config/wizardlm-7b.yaml: Language not supported
Comments suppressed due to low confidence (2)
core/action/custom.go:49
- The type assertion for the 'Init' function may panic if the evaluated value does not match the expected signature. Consider using a comma-ok check to safely handle incorrect types.
run := v.Interface().(func() error)
.github/workflows/image.yml:22
- [nitpick] There might be a typo in the Docker image name 'localagi'; check if it should be 'localagent' in order to match the project naming.
DOCKER_IMAGE=quay.io/mudler/localagi
Comment on lines
+90
to
+91
| run := v.Interface().(func(map[string]interface{}) (string, map[string]interface{}, error)) | ||
|
|
There was a problem hiding this comment.
The type assertion for the 'Run' function could lead to a panic if the evaluated function does not have the expected signature. Using a safe type assertion (with comma-ok) would improve the robustness of the code.
Suggested change
| run := v.Interface().(func(map[string]interface{}) (string, map[string]interface{}, error)) | |
| run, ok := v.Interface().(func(map[string]interface{}) (string, map[string]interface{}, error)) | |
| if !ok { | |
| return types.ActionResult{}, fmt.Errorf("invalid function signature for Run") | |
| } |
Signed-off-by: mudler <mudler@localai.io>
Signed-off-by: mudler <mudler@localai.io>
Signed-off-by: mudler <mudler@localai.io>
Signed-off-by: Richard Palethorpe <io@richiejp.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a complete rewrite of LocalAGI in go, with an additional WebUI to manage, create, connect a swarm of agents.
There are many new capabilities added, and the language was moved away from Python. The rewriting started almost 2 years ago, so it took time to complete because was mainly working on it during my spare time. However now @richiejp is jumping in helping in, and we also have a fantastic web interface (thanks!) so things looks solid to release and swap with the old core.
There are minor things to tweak along the way, but this should be a good baseline from now on.
The goal of the project is unchanged: be able to host Agents on your own hardware, with less configuration as possible, with sane defaults. There are two flavors (CPU and GPU) that can be both tweaked easily from the docker-compose files.