Remove unnecessary lifetime for OplogBuilder::new #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
> If there is exactly one input lifetime position (elided or not), that > lifetime is assigned to all elided output lifetimes. (https://doc.rust-lang.org/beta/nomicon/lifetime-elision.html)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(https://doc.rust-lang.org/beta/nomicon/lifetime-elision.html)
I tried to remove this lifetime too as the same rule should apply, but the compiler wasn't happy. Strangely, it compiled when I changed
OplogBuildertoSelfin the return value, but I didn't want to make that change because then the signature would be inconsistent with the others.