Added download instructions for Linux users and updated README#43
Open
HunterKimes wants to merge 4 commits intomtytel:mainfrom
Open
Added download instructions for Linux users and updated README#43HunterKimes wants to merge 4 commits intomtytel:mainfrom
HunterKimes wants to merge 4 commits intomtytel:mainfrom
Conversation
Add periods to the end of some sentences.
Add Install_for_Linux instructions.
Fixed quotes. Planning to add a bit more detail to steps.
Added more detail to install instructions.
antazoey
reviewed
Jun 5, 2023
| @@ -0,0 +1,11 @@ | |||
| How to Install Vital on Ubuntu | |||
There was a problem hiding this comment.
Cool Pull Request! Here is some feedback:
- Instead of making a new file, you would probably want to edit the README.md, in the
Installingsection. - You generally wouldn't want to include instructions this verbose regarding what buttons to click etc. because websites change often and trying to maintain a README like that would be difficult.
- A good example of OS-specific install instructions would be parts that were unique to that OS. Much of these instructions are the same regardless of which OS the user is using.
(btw only offering this feedback because this is generally part of the GitHub process; you open PRs and get feedback, but if I was a maintainer of this project, I would not merge this... maybe except for the period-additions in the README.md, just cuz).
good luck out there! <3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello, I'm doing this pull request for an assignment. Feel free to disregard this, I know you don't accept pull requests. I wanted to use Vital for my class project because it really inspires me and I wanted to better understand GitHub. Thanks.