New utility function to generate a polarities array from a dictionary.#343
Open
New utility function to generate a polarities array from a dictionary.#343
Conversation
@SeismoFelix pointed out that this function has been removed from the main branch. This is a re-introduction with a very minimal change, to replace the .format() with a f string.
Member
|
Could you please? |
Member
Author
|
Hi @rmodrak, thanks for the suggestions. Should be ready to merge if that's fine for you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This functions addresses a need to provide a sorted array for polarities values [-1,0,1] for each stations, from a polarity dictionary.
From the
Waveforms+Polarities.pyexample:it replaces the following loop:
and adds warning prints if there is a discrepancy between the names in
stationsandpolarities_dict.Mostly straightforward PR, but I am happy to get any feedback if you think it is too redundant (@rmodrak, @ammcpherson, @SeismoFelix).
Planning to merge en Feb 26th.