Header patch for plot_data_greens3 and misc fix related to waveform figure#339
Header patch for plot_data_greens3 and misc fix related to waveform figure#339
Conversation
This should solve issue #332. Also added rescaling mecanism for line to avoid line clipping out of header in waveform figures. This triggers per-line (only the line that would overflow is rescaled). I tested it on the mtuq examples and it looks okay to me. Also tested with plot_data_greens3 and everything looks fine as well. I turned it on by default, but we could change that if needed.
Changed default behavior for collect_synthetics (but also collect_attributes, even if not really used much in the code -- for consistency). I also noticed that if the normalized misfit per trace was not stored as attributes in the level0, then it would divide the raw misfit by the total (normalized) misfit. So in the 2009 eq event, this translates to doing ~1e-9 / ~1e0 'hybrid' had not been properly implemented, so I did a light rework of the calculate_norm_data function.
Python 3.14 (released oct of this year) seems to cause issues with the continuous integration tests, so I fixed it to 3.13.
|
|
Good point, I did implemented an adaptive font size for the header display, but the text might still clip-out if the path is very long. The last commit make it so the path is completely stripped down to the folder name of the model. Testing on my side yield this for
There is a slight difference in header look between the 1 and the [2, 3] versions of the figure, because the And just to be sure @aakash10gupta, what do you mean by?:
|
|
Since your PR title says |



Clean-reset of the
waveform_plot_updatebranch, which makes a clean slate based of PR #333It should fix both issues #332 and #335.
It introduces several enhancements and bug fixes. It is still mostly focused on improving the waveform figure (header fix, misfit normalization/contribution fix), and I took the opportunity to fix the GitHub python workflows that was broken with the release of Python 3.14.
Will merge before the end of the week and delete PR #333 unless there is an objection.
tag: @rmodrak, @ammcpherson, @aakash10gupta
Old message from #333 for quick reference