Minor bugfix to account for only 12 columns in weight file#325
Minor bugfix to account for only 12 columns in weight file#325ammcpherson wants to merge 1 commit intomtuqorg:masterfrom
Conversation
|
Can we generalize the weight file format and reader to accommodate different existing conventions? Following discussion with others in 2020, I started using a 13 column weight file (introduced by Celso?) and still continue to use it |
|
If the order never changes, we could do something akin to: But I think that if we are encouraging people to use PySEP to download data, this will always fall victim to needing to be kept up to date with whatever changes happen there. |
|
I have two more thoughts regarding this:
I think that the long term solution is to ask for PySEP to write out a weights file with a descriptive header, such that we can write a function to read it in as a pandas DataFrame with column names, which would be about as generalized as I think it could be. In the short term though, I think that we need to have this fixed for new users. |
Hello,
I believe that at one point the weights files had 13 columns, and at some point this changed to only 12. I have updated the parse_statistics function to read in the proper columns for static time shifts.
Thanks,
Amanda