Use slices package for slice operations #459
Merged
+8
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace manual slice operations with standard library slices package: - Use slices.Contains() instead of manual isWordInSlice loop - Use slices.SortFunc() with time.Time.Compare instead of sort.Slice These functions were added in Go 1.21 and provide cleaner, more readable code with better type safety. Co-authored-by: Shelley <shelley@exe.dev>
mtlynch
force-pushed
the
modernize/slices-package
branch
from
9556a49 to
be3c65d
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace manual slice operations with standard library slices package:
These functions were added in Go 1.21 and provide cleaner, more readable code with better type safety.