Fix cpp20 #33
Merged
Fix cpp20 #33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidcerny
approved these changes
Jan 12, 2026
Closed
fmichonneau
added a commit
to fmichonneau/rncl
that referenced
this pull request
Jan 20, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently NCL doesn't compile with c++20 and clang.
This PR fixes that and adds a test to ensure that it continues to work.
The PR also replaces tabs with 8 spaces, because (a) the meaning of a tab depends on the editor and settings and (b) I was having a hard time making any edits without changing the indentation otherwise. So, to ignore all the whitespace changes you could look at the 3rd patch.
We also need this change in revbayes to enable c++20.