support for interleave=[yes/no] #20
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NCL supports
INTERLEAVEandNOINTERLEAVE, while many software (e.g., MrBayes, PAUP*, etc.) supportINTERLEAVE=YESandINTERLEAVE=NO(NCL halts processing and reports an error on this). NCL follows the original Nexus definition (Maddison et al., 1997), but since so many packages support both formats it seems reasonable that NCL should as well.This simple edit adds support for the latter to NCL (
NxsCharactersBlock::HandleFormat()).Note:
nxsdistancesblock.cppalso parses interleave statements (NxsDistancesBlock::HandleFormatCommand()), but does so in a different way (token.GetNextToken()rather than iterating through a tokenized vector). Presumably atoken.PeekNextToken()function could be added to mirror functionality above.