Skip to content

Conversation

@cx384
Copy link
Contributor

@cx384 cx384 commented Oct 3, 2025

Most spawn by water source trees (including rubber trees) will never spawn.
(spawn_by and num_spawn_by is only for the 8 neighboring nodes at y coordinate -1.)
This is horrible if you actually want to use this mod, it has been a long time since I last did.
Fixes #48 #33 and forum posts.

Only for trees that grow in water (not even for palms), it would make sense to use spawn by water.
So I removed most of it. For palms, restricting y_max works better.

I tested it (in MTG) and found every tree in a reasonable about of time. Also, the trees are not too common, imo.

It's not perfect, a better solution would use biomes in the decoration definition depending on their heat_point and humidity_point, but I don't want to figure out numbers and deal with compatibility problems.
So with this PR at least all trees (including rubber trees) will spawn again.

Moreover, note that the trees still don't spawn on default:dirt_with_dry_grass, default:dry_dirt_with_dry_grass and default:dirt_with_snow (the latter would require special snow covered saplings.)
Feel free to make improvements

Copy link
Contributor

@wsor4035 wsor4035 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems legit. leaving this open for a day before merging in case anyone wants to comment

@wsor4035 wsor4035 merged commit 403b16f into mt-mods:master Oct 4, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Invalid values for near_nodes_count in biome_defs.lua inhibit the existence of certain trees.

2 participants