Make all trees spawn again #57
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most spawn by water source trees (including rubber trees) will never spawn.
(
spawn_byandnum_spawn_byis only for the 8 neighboring nodes at y coordinate -1.)This is horrible if you actually want to use this mod, it has been a long time since I last did.
Fixes #48 #33 and forum posts.
Only for trees that grow in water (not even for palms), it would make sense to use spawn by water.
So I removed most of it. For palms, restricting
y_maxworks better.I tested it (in MTG) and found every tree in a reasonable about of time. Also, the trees are not too common, imo.
It's not perfect, a better solution would use biomes in the decoration definition depending on their
heat_pointandhumidity_point, but I don't want to figure out numbers and deal with compatibility problems.So with this PR at least all trees (including rubber trees) will spawn again.
Moreover, note that the trees still don't spawn on
default:dirt_with_dry_grass,default:dry_dirt_with_dry_grassanddefault:dirt_with_snow(the latter would require special snow covered saplings.)Feel free to make improvements