Skip to content

Remove nonexistent waving paramtype2 from saplings #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
wsor4035 merged 1 commit into from
Oct 1, 2025
Merged

Remove nonexistent waving paramtype2 from saplings #56

wsor4035 merged 1 commit into from
Oct 1, 2025

Conversation

@Niklp09
Copy link
Member

@Niklp09 Niklp09 commented Oct 1, 2025

Saplings should not wave, the removed code also didn't work.

2025-09-17 17:12:28: WARNING[Main]: Node moretrees:apple_tree_sapling has unknown paramtype2 "waving"
2025-09-17 17:12:28: WARNING[Main]: Node moretrees:apple_tree_sapling_ongen has unknown paramtype2 "waving"
2025-09-17 17:12:28: WARNING[Main]: Node moretrees:oak_sapling has unknown paramtype2 "waving"
2025-09-17 17:12:28: WARNING[Main]: Node moretrees:oak_sapling_ongen has unknown paramtype2 "waving"
2025-09-17 17:12:28: WARNING[Main]: Node moretrees:sequoia_sapling has unknown paramtype2 "waving"
2025-09-17 17:12:28: WARNING[Main]: Node moretrees:sequoia_sapling_ongen has unknown paramtype2 "waving"
2025-09-17 17:12:28: WARNING[Main]: Node moretrees:birch_sapling has unknown paramtype2 "waving"
2025-09-17 17:12:28: WARNING[Main]: Node moretrees:birch_sapling_ongen has unknown paramtype2 "waving"
2025-09-17 17:12:28: WARNING[Main]: Node moretrees:palm_sapling has unknown paramtype2 "waving"
2025-09-17 17:12:28: WARNING[Main]: Node moretrees:palm_sapling_ongen has unknown paramtype2 "waving"
2025-09-17 17:12:28: WARNING[Main]: Node moretrees:date_palm_sapling has unknown paramtype2 "waving"
2025-09-17 17:12:28: WARNING[Main]: Node moretrees:date_palm_sapling_ongen has unknown paramtype2 "waving"
2025-09-17 17:12:28: WARNING[Main]: Node moretrees:spruce_sapling has unknown paramtype2 "waving"
2025-09-17 17:12:28: WARNING[Main]: Node moretrees:spruce_sapling_ongen has unknown paramtype2 "waving"
2025-09-17 17:12:28: WARNING[Main]: Node moretrees:cedar_sapling has unknown paramtype2 "waving"
2025-09-17 17:12:28: WARNING[Main]: Node moretrees:cedar_sapling_ongen has unknown paramtype2 "waving"
2025-09-17 17:12:28: WARNING[Main]: Node moretrees:poplar_sapling has unknown paramtype2 "waving"
2025-09-17 17:12:28: WARNING[Main]: Node moretrees:poplar_sapling_ongen has unknown paramtype2 "waving"
2025-09-17 17:12:28: WARNING[Main]: Node moretrees:poplar_small_sapling has unknown paramtype2 "waving"
2025-09-17 17:12:28: WARNING[Main]: Node moretrees:poplar_small_sapling_ongen has unknown paramtype2 "waving"
2025-09-17 17:12:28: WARNING[Main]: Node moretrees:willow_sapling has unknown paramtype2 "waving"
2025-09-17 17:12:28: WARNING[Main]: Node moretrees:willow_sapling_ongen has unknown paramtype2 "waving"
2025-09-17 17:12:28: WARNING[Main]: Node moretrees:rubber_tree_sapling has unknown paramtype2 "waving"
2025-09-17 17:12:28: WARNING[Main]: Node moretrees:rubber_tree_sapling_ongen has unknown paramtype2 "waving"
2025-09-17 17:12:28: WARNING[Main]: Node moretrees:fir_sapling has unknown paramtype2 "waving"
2025-09-17 17:12:28: WARNING[Main]: Node moretrees:fir_sapling_ongen has unknown paramtype2 "waving"
2025-09-17 17:12:28: WARNING[Main]: Node moretrees:jungletree_sapling_ongen has unknown paramtype2 "waving"

wsor4035
wsor4035 approved these changes Oct 1, 2025
View reviewed changes
Copy link
Contributor

@wsor4035 wsor4035 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems legit

@wsor4035 wsor4035 merged commit 7c690ed into master Oct 1, 2025
2 checks passed
@wsor4035 wsor4035 deleted the waving branch October 1, 2025 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wsor4035 wsor4035 wsor4035 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Niklp09 @wsor4035