Skip to content
This repository was archived by the owner on May 10, 2024. It is now read-only.

enhancement: show specified n, slope and depth/WSE in cross-section display#5

Open
AlisterH wants to merge 14 commits intomsweier:masterfrom
AlisterH:enhance_output
Open

enhancement: show specified n, slope and depth/WSE in cross-section display#5
AlisterH wants to merge 14 commits intomsweier:masterfrom
AlisterH:enhance_output

Conversation

@AlisterH
Copy link

@AlisterH AlisterH commented Jan 9, 2019

The cross-section display shows almost all the information required for many purposes. This pull request adds the specified depth/WSE, roughness and channel slope, which essentially allows it to be presented standalone, or just with the rating curve.

When defining a trapezoidal channel it should really display the specified bottom width and side slopes as well, but that makes the layout trickier - ideally the dimensions could be shown on the actual cross-section though, with just the results shown to the right. Alternatively, if you consider that the dimensions don't really need to included, you might just want to add the roughness and channel slope, and leave out the depth/WSE.

@AlisterH
Copy link
Author

AlisterH commented Jan 9, 2019

flowestimatorresultsxsfigure

@msweier
Copy link
Owner

msweier commented Jan 9, 2019

Thanks for your input. I'm glad you have found the plugin useful. Unfortunately, I am unable to continue development at this time. Feel free to fork and fix the issues.

@AlisterH
Copy link
Author

AlisterH commented Jan 7, 2020

Hi,

Unfortunately, I am unable to continue development at this time.

I presume this is still the case.

Feel free to fork and fix the issues.

I have now adapted it to work in QGIS 3.x as well as 2.x, and am hoping to fix one more issue before making a release (I'm now working in my master branch if anyone is wanting to look at the changes).
Would you be OK with me releasing it as a new version of the same plugin, rather than renaming it to create a new plugin? I don't see any benefit in releasing it as a new plugin, and I'm sure any current users would appreciate being notified of the new version.

Thanks.

@msweier
Copy link
Owner

msweier commented Jan 8, 2020 via email

@pcav
Copy link

pcav commented May 13, 2020

Done, please check.
Cheers.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants