Drycleaned fragCounter input for JaBbA causes drop of SVs during edge selection#14
Open
pblaney wants to merge 19 commits intomskilab-org:masterfrom
Open
Drycleaned fragCounter input for JaBbA causes drop of SVs during edge selection#14pblaney wants to merge 19 commits intomskilab-org:masterfrom
pblaney wants to merge 19 commits intomskilab-org:masterfrom
Conversation
|
Hello, @pblaney |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello @mskilab,
I see on the
JaBbArepo that a 'best practices' are in the works so this might have come up in already.However, I figured it'd best to detail my thoughts and get an opinion on if this is reasonable.
The behavior I am experiencing occurs when using newly drycleaned fragCounter coverage with JaBbA, the algorithm excludes numerous (but not all) junctions due to "both breakpoints are in NA coverage regions". From what I see in the code, this has a direct impact on the edges selected in from the graph and should to be included (those lost include both inter- and intra- chromosomal breakpoints).
My quick assessment was the input SVs were properly read as input and then dropped as the drycleaned fragCounter coverage contained gaps in the coverage where this would lead to a NA value for the foreground. Considering the original fragCounter input (pre-drycleaning) is binned across the entire genome, I suspected there should be no gaps especially after drycleaning (I believed this is one of the reasons for this step).
To see what occurred between the drycleaning and original fragCounter coverage, I ran
start_wash_cyclechanging only the germline filter to FALSE:Interestingly, this revealed a drycleaned fragCounter coverage profile with the same number of bins as the input (i.e. there weren't any gaps in the GRanges). Given this change, I searched the code base and found lines 784-806 in dryclean.R:
The problem is all the NA records in the
covobject. Under either condition forgermline.filter, there coverage regions that are evaluated to NA that are used for input in JaBbA which causes issues downstream.My thought process in solving this two-sided issue was:
If we are confident to set
foreground == 0wheninput.read.counts == 0, then a reasonable assumption would be that in all scenarios whereis.na(input.read.counts) == TRUEwe can should setforegroundto some small non-zero value. I choseexp(-5)as this was the lowest I saw for the range offoreground.login some of my fragCounter cov files.The main issue is the NA for segments where
germline.status == TRUE, while this will achieve the desired effect of not having these FPs appear as enriched SCNAs but something like GISTIC. However, the NAs can cover regions where a somatic SVs breakpoint resides, leading to its exclusion. I reasoned an alternative would be that in all scenarios wheregermline.status == TRUEwe can should setforegroundtomedian.chr. I feel would achieve the same effect of reducing the potential FP enrichment of SCNAs for these regions in a patient series (with potential exceptions in extreme aneuploidy of single chromosomes perhaps).After some troubleshooting runs with dryclean and JaBbA, I have gotten stable results in a variety of JaBbA execution parameters. All of these runs have recovered the nearly all of the previous excluded SVs in the model.
I will continue to test but would interested to hear thoughts on this.
Best,
Patrick