Open
Conversation
Due to hardcoded GDB_ROOT and OCAML_ROOT, $CC was not able to find headers. Fixes mshinwell#7 Signed-off-by: Justin Cinkelj <justin.cinkelj@xlab.si>
Add to gdb_backend/to_gdb.c
stack.h for iterate_over_block_local_vars()
target/target.h for target_read_memory()
Add to gdb_backedn/from_gdb.c
value.h for value_lval_const(), value_bits_synthetic_pointer()
c-lang.h for c_val_print()
Func c_val_print() was called with 9 parameters, but declaration in
c-lang.h has only 8:
extern void c_val_print (struct type *, const gdb_byte *,
int, CORE_ADDR,
struct ui_file *, int,
const struct value *,
const struct value_print_options *);
I guess the last (depth) param is excessive, so it was removed that one.
Signed-off-by: Justin Cinkelj <justin.cinkelj@xlab.si>
Author
|
When I try to 'opam install mirage' I get errors like: I have no idea if this is related to this pull request (I have zero OCaml knowledge). I was able to install, compile and run mirage with 4.05.0 switch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I had to apply those small changes to be able to execute
opam install -j4 -y libmonda-gdb.