perf: replace python-dotenv with custom fast parser - 5x faster cold start #33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Complete project structure overview - Common commands and workflows - Release process (always use ./scripts/release.sh) - Architecture details and optimizations - Linting, testing, and CI/CD guides - Troubleshooting tips This file provides context for Claude Code to work more effectively with the project without repeating instructions.
🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
…start Replace python-dotenv dependency with custom-built fast_dotenv.py parser, achieving significant performance improvements while maintaining full compatibility. Performance improvements: - Cold start: 0.39ms (5.0x faster than pydantic, was 1.5x) - Warm cached: 0.012ms (267x faster than pydantic, was 112x) - Cache effectiveness: 29.7x internal speedup Key changes: - Add fast_dotenv.py (170 lines, zero dependencies) - Remove python-dotenv from dependencies - Update settings.py to use fast_dotenv - Add 59 comprehensive tests for fast_dotenv - Clean up duplicate code in settings.py - Update README with new performance numbers Technical details: - UTF-8 BOM support - Escape sequences parsing (\n, \t, etc) - Export keyword handling - Strict variable name validation (isidentifier) - Global caching for repeated loads - Optimized string operations with local references All 81 tests passing (22 settings + 59 fast_dotenv) Zero external dependencies added (removed 1)
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Change chmod from 0o644 (world-readable) to 0o600 (owner-only) in test_file_permission_error cleanup to address CodeQL security warning. The permission test still passes with owner-only permissions.
- Fix import sorting and organization - Replace single quotes with double quotes for consistency - Remove trailing whitespace from blank lines - Fix quote escaping in test strings - Format long lines and dictionaries for better readability - Apply consistent formatting across test files All ruff checks now pass successfully.
Contributor
Author
|
/merge |
|
✅ PR merged successfully by @vilsonrodrigues! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Replaces the dependency with a custom-built parser, achieving significant performance improvements while maintaining full compatibility and adding zero external dependencies.
Performance Improvements
Cold start (first load):
Warm cached (repeated loads):
Cache effectiveness:
Key Changes
Added
src/msgspec_ext/fast_dotenv.py(170 lines)tests/test_fast_dotenv.py(59 comprehensive tests)Changed
pyproject.toml: Removedpython-dotenvdependencysettings.py: Import fromfast_dotenvinstead ofdotenvREADME.md: Updated performance numbers and features_preprocess_env_valueRemoved
python-dotenvdependency (was the only external dep besides msgspec)Testing
✅ All 81 tests passing:
uv run pytest tests/ -v # 81 passed in 0.23sBenchmarks
Results:
Code Quality
✅ Lint passing:
uv run ruff check src/ # All checks passed✅ Code style:
str | Nonenoqaneeded (clean code)Migration Impact
Breaking changes: None ✅
This is a drop-in replacement with identical API:
Dependencies:
Benefits
🚀 Generated with Claude Code
Co-Authored-By: Claude noreply@anthropic.com