Skip to content

Improve tqdm progress bar when sampling tables of known sizes #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
msg555 merged 1 commit into from
Mar 29, 2025
Merged

Improve tqdm progress bar when sampling tables of known sizes #35

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions subsetter/sampler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -692,6 +692,7 @@ def __init__(self, source: DatabaseConfig, config: SamplerConfig) -> None:
self.compact_columns: Dict[Tuple[str, str], Set[str]] = {}
self.temp_tables = TempTableCreator()
self.passthrough_tables: Set[str] = set()
self.cached_table_sizes: Dict[Tuple[str, str], int] = {}

def sample(
self,
Expand Down Expand Up @@ -866,6 +867,7 @@ def _materialize_tables(
primary_key=table.primary_key,
)
)
self.cached_table_sizes[(schema, table_name)] = rowcount
LOGGER.info(
"Materialized %d rows for %s.%s in temporary table",
rowcount,
Expand Down Expand Up @@ -1005,9 +1007,9 @@ def _copy_results(

rows = 0

def _count_rows(result):
def _count_rows(result, total: Optional[int]):
nonlocal rows
for row in tqdm(result, desc="row progress", unit="rows"):
for row in tqdm(result, total=total, desc="row progress", unit="rows"):
# result_processor
rows += 1
yield row
Expand All @@ -1017,7 +1019,7 @@ def _count_rows(result):
schema,
table_name,
columns,
_count_rows(result),
_count_rows(result, self.cached_table_sizes.get((schema, table_name))),
filter_view=filter_view,
multiplier=(
1
Expand Down