Improved availability and HVAC action logic in ComfoClimeClimate #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR attempts to improve the availability logic and HVAC action handling in the ComfoClime climate integration by using bitwise operations to return multiple HVAC actions simultaneously. However, the changes introduce several critical issues that break compatibility with Home Assistant's ClimateEntity API.
Key changes:
- Modified availability check to use OR logic between two coordinators
- Changed hvac_action return type from single HVACAction to list[HVACAction]
- Rewrote bitwise logic to return multiple active states simultaneously
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been experimenting a bit with bitwise operations and came up with the following.
Since Hassio allows passing multiple HVACActions, I programmed this and it's currently in use in my system.Addendum:
The documentation states that only a status needs to be returned, but the frontend processes this correctly -> (https://github.com/home-assistant/frontend/blob/eb74dd541a6c98b994c98144045ee851156f0f46/src/common/entity/compute_attribute_display.ts#L97).
I think that if ComfoClime is already providing this information, it should at least be displayed.