Allow resume when downloading crash. aiofile depency removed#3
Open
poneoneo wants to merge 6 commits intomsemple1111:masterfrom
Open
Conversation
…ad of starting from the beginning
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm a bit annoying when I need to restart the download process from the 0 each time time a stream fails to download before the end. Its could be great if I can resume where we left and restart to dl at this point instead of restart
That is the feature that I want to see in pytube_async. Last time you said me that aio buffer is not important cause write will be always sync then I have removed so on_progresse will no longer a couroutine and will comme back to a simple func.