Open
Conversation
Owner
|
Thank you! I will have a look at the pull request as soon as I have time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When I tried to compile your package I got undefined reference error on my machine (Ubuntu 18.04, Melodic). This can be easily fixed by adding rqt_gui_cpp rqt_gui in find_package. Additionally, I fixed some minor issues using catkin_lint. :)
This was the undefined reference error I got:
CMakeFiles/aeplanner.dir/src/aeplanner_nodelet.cpp.o: In function `aeplanner::AEPlannerNodelet::onInit()': /home/naazare/ros/src/aeplanner/aeplanner/src/aeplanner_nodelet.cpp:12: undefined reference to `nodelet::Nodelet::getMTNodeHandle() const' CMakeFiles/aeplanner.dir/src/aeplanner_nodelet.cpp.o: In function `aeplanner::AEPlannerNodelet::~AEPlannerNodelet()': /home/naazare/ros/src/aeplanner/aeplanner/src/aeplanner_nodelet.cpp:15: undefined reference to `nodelet::Nodelet::~Nodelet()' CMakeFiles/aeplanner.dir/src/aeplanner_nodelet.cpp.o: In function `class_loader::impl::MetaObject<aeplanner::AEPlannerNodelet, nodelet::Nodelet>::create() const': /home/naazare/ros/src/aeplanner/aeplanner/include/aeplanner/aeplanner_nodelet.h:10: undefined reference to `nodelet::Nodelet::Nodelet()' CMakeFiles/aeplanner.dir/src/aeplanner_nodelet.cpp.o: In function `void class_loader::impl::registerPlugin<aeplanner::AEPlannerNodelet, nodelet::Nodelet>(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&)': /opt/ros/melodic/include/class_loader/class_loader_core.hpp:177: undefined reference to `class_loader::impl::getCurrentlyLoadingLibraryName[abi:cxx11]()' /opt/ros/melodic/include/class_loader/class_loader_core.hpp:177: undefined reference to `class_loader::impl::getCurrentlyActiveClassLoader()' /opt/ros/melodic/include/class_loader/class_loader_core.hpp:183: undefined reference to `class_loader::impl::getCurrentlyActiveClassLoader()' CMakeFiles/aeplanner.dir/src/aeplanner_nodelet.cpp.o: In function `void class_loader::impl::registerPlugin<aeplanner::AEPlannerNodelet, nodelet::Nodelet>(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&)': /opt/ros/melodic/include/class_loader/meta_object.hpp:153: undefined reference to `class_loader::impl::AbstractMetaObjectBase::AbstractMetaObjectBase(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&)' /opt/ros/melodic/include/class_loader/meta_object.hpp:155: undefined reference to `typeinfo for nodelet::Nodelet' CMakeFiles/aeplanner.dir/src/aeplanner_nodelet.cpp.o: In function `void class_loader::impl::registerPlugin<aeplanner::AEPlannerNodelet, nodelet::Nodelet>(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&)': /opt/ros/melodic/include/class_loader/class_loader_core.hpp:206: undefined reference to `class_loader::impl::getCurrentlyActiveClassLoader()' /opt/ros/melodic/include/class_loader/class_loader_core.hpp:206: undefined reference to `class_loader::impl::AbstractMetaObjectBase::addOwningClassLoader(class_loader::ClassLoader*)' /opt/ros/melodic/include/class_loader/class_loader_core.hpp:207: undefined reference to `class_loader::impl::getCurrentlyLoadingLibraryName[abi:cxx11]()' /opt/ros/melodic/include/class_loader/class_loader_core.hpp:207: undefined reference to `class_loader::impl::AbstractMetaObjectBase::setAssociatedLibraryPath(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >)' /opt/ros/melodic/include/class_loader/class_loader_core.hpp:211: undefined reference to `class_loader::impl::getPluginBaseToFactoryMapMapMutex()' /opt/ros/melodic/include/class_loader/class_loader_core.hpp:136: undefined reference to `class_loader::impl::getFactoryMapForBaseClass(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&)' /opt/ros/melodic/include/class_loader/class_loader_core.hpp:225: undefined reference to `class_loader::impl::getPluginBaseToFactoryMapMapMutex()' /opt/ros/melodic/include/class_loader/class_loader_core.hpp:200: undefined reference to `class_loader::impl::hasANonPurePluginLibraryBeenOpened(bool)' CMakeFiles/aeplanner.dir/src/aeplanner_nodelet.cpp.o: In function `void class_loader::impl::registerPlugin<aeplanner::AEPlannerNodelet, nodelet::Nodelet>(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&)': /opt/ros/melodic/include/class_loader/meta_object.hpp:153: undefined reference to `class_loader::impl::AbstractMetaObjectBase::~AbstractMetaObjectBase()' CMakeFiles/aeplanner.dir/src/aeplanner_nodelet.cpp.o:(.data.rel.ro._ZTIN9aeplanner16AEPlannerNodeletE[_ZTIN9aeplanner16AEPlannerNodeletE]+0x10): undefined reference to `typeinfo for nodelet::Nodelet' collect2: error: ld returned 1 exit status make[2]: *** [/home/naazare/ros/devel/.private/aeplanner/lib/libaeplanner.so] Error 1 make[1]: *** [CMakeFiles/aeplanner.dir/all] Error 2 make[1]: *** Waiting for unfinished jobs.... make: *** [all] Error 2