Skip to content

remove use of this with TextDecoder #348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tim-smart wants to merge 2 commits into
base: master
Choose a base branch
from
Open

remove use of this with TextDecoder #348

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1729ad5
remove use of `this` with TextDecoder
tim-smart Oct 18, 2023
8313824
make charset an explicit argument to decoders.other
tim-smart Oct 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions lib/utils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -413,7 +413,7 @@ function getDecoder(charset) {
charset = charset.toLowerCase();
continue;
}
return decoders.other.bind(charset);
return decoders.other(charset);
}
}
}
Expand Down Expand Up @@ -458,13 +458,13 @@ const decoders = {
return data.base64Slice(0, data.length);
},

other: (data, hint) => {
other: (charset) => (data, hint) => {
if (data.length === 0)
return '';
if (typeof data === 'string')
data = Buffer.from(data, 'latin1');
try {
const decoder = new TextDecoder(this);
const decoder = new TextDecoder(charset);
return decoder.decode(data);
} catch {}
},
Expand Down