refactor(shared): move redis_management to autobot-shared (#2313)#2469
Merged
mrveiss merged 1 commit intoDev_new_guifrom Mar 26, 2026
Merged
refactor(shared): move redis_management to autobot-shared (#2313)#2469mrveiss merged 1 commit intoDev_new_guifrom
mrveiss merged 1 commit intoDev_new_guifrom
Conversation
Move redis_management/ from autobot-backend/utils/ to autobot-shared/ so all components share the same connection management code. Backend-specific constant imports (REDIS_CONFIG, RetryConfig, TimingConstants) replaced with inline values. Backend config_manager and prometheus_metrics use lazy imports. - types.py, statistics.py: moved as-is (no backend deps) - config.py: replaced constant imports with literal defaults - connection_manager.py: lazy imports for config_manager and metrics - Old __init__.py replaced with backward-compat shim - redis_client.py updated to import from new location
✅ SSOT Configuration Compliance: Passing🎉 No hardcoded values detected that have SSOT config equivalents! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
redis_management/fromautobot-backend/utils/toautobot-shared/as the canonical locationREDIS_CONFIG,RetryConfig,TimingConstants) replaced with inline literal valuesconfig_managerandprometheus_metricsuse lazy imports (available when running under backend, gracefully absent otherwise)autobot-shared/redis_client.pyupdated to import from new shared locationautobot-backend/utils/redis_management/__init__.pyreplaced with backward-compat shimFiles moved
types.py— as-is (no backend deps)statistics.py— as-is (no backend deps)config.py— inlined constant defaults, usesautobot_shared.network_constantsconnection_manager.py— lazy imports for backend-specific modulesCloses #2313
Test plan
from utils.redis_management import RedisConnectionManagerstill works (backward compat shim)from autobot_shared.redis_management import RedisConnectionManagerworks (new canonical import)