Skip to content

Conversation

@bambam955
Copy link
Contributor

Changes

  • Updated npm dependencies
  • Added basic pre-commit hooks

@bambam955 bambam955 requested a review from Pertempto December 12, 2025 19:10
@bambam955 bambam955 self-assigned this Dec 12, 2025
@github-actions
Copy link

@bambam955 — quick note on package.json changes:

  • You bumped astro from ^5.6.1 -> ^5.16.5 and @astrojs/starlight -> ^0.37.1. Those are non-trivial upgrades and can introduce breaking changes.
  • Please confirm you ran a full local build and smoke-tested the site (recommended: npm ci && npm run build && npm run dev).
  • Verify starlight-blog and sharp still work with the new Astro and Starlight versions; if you hit issues, include the failing logs or tests.

Also confirm the "name": "@mrs-electronics/dev-site" and "private": true changes are intentional.

@github-actions
Copy link

Changes Requested

  • Run and report results of local build + dev smoke tests after dependency upgrades.
  • Confirm package.json metadata changes (name and private) are intentional.
  • Add brief note in PR description about why these specific dependency versions were chosen and any migration steps taken.

Summary of Changes

  • Added .pre-commit-config.yaml with basic pre-commit hooks: trailing-whitespace, end-of-file-fixer, check-yaml, check-added-large-files.
  • Updated package.json:
    • Set name to @mrs-electronics/dev-site and private to true.
    • Upgraded @astrojs/starlight from ^0.35.2 to ^0.37.1.
    • Upgraded astro from ^5.6.1 to ^5.16.5.
    • Kept sharp and starlight-blog as-is.
  • package-lock.json changed (large lockfile update).

Overall Feedback

  • Negative: The dependency bumps look reasonable but can introduce breaking changes; I need confirmation you ran builds and checked compatibility (especially sharp and starlight-blog against the new Astro/Starlight versions). Please include test/build results or CI passing status. Also confirm the package.json metadata changes are intentional.

  • Positive: Good addition of a lightweight set of pre-commit hooks — they should help maintain repo hygiene. Thanks for keeping deps up to date!

�44D�3FB

@bambam955
Copy link
Contributor Author

Code review bot, I did confirm that npm ci && npm run build && npm run dev complete with no errors 🚀

Copy link
Contributor

@Pertempto Pertempto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bambam955 bambam955 merged commit e1b7c87 into main Dec 16, 2025
1 check passed
@bambam955 bambam955 deleted the bm-update-deps branch December 16, 2025 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants