-
Notifications
You must be signed in to change notification settings - Fork 0
docs: add basic specs #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@bambam955 no rush on this one. I just wanted to write it all down before I take a break from the project for a bit. |
This comment was marked as outdated.
This comment was marked as outdated.
Changes RequestedPlease address the following before merging:
Summary of Changes
Overall Feedback
@Pertempto — ping me after you push the frontmatter/date and CONTRIBUTING updates and I will re-check quickly. |
The requirements I was given weren't this specific, so I'm not going to be that specific in the spec. |
|
Marking as draft until I can document the spec system and link it in the README. Also I plan to remove the opencode commands. I've found it more useful to put information in |
|
I would agree with removing the custom opencode commands. I personally don't use opencode much anymore so if I were to help develop this project I'd have to either change my development workflow or add copies of those commands to the list for whatever agent I am using. |
|
I need to add a link to this repo: https://github.com/specture-system/specture Right now it just contains a basic README, in the future I plan to include more docs and tooling. |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
No epics in the Specture system. I have clarified this. |
Co-authored-by: Addison Emig <addison.emig@mrs-electronics.com> Signed-off-by: Bennett Moore <120052232+bambam955@users.noreply.github.com>
bambam955
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall I really like this approach to feature tracking. It's definitely taking some mental rewiring to get used to but I really appreciate that it focuses more on the "why" for a feature and avoids tons of implementation details.
I left some comments: mostly grammatical/wording, plus some notes about legit system revisions.
|
One major flaw with the current design of Specture - there is no way to track who is actually implementing the change. There is an author field, but maybe there should also be an optional Long term, there could be CI/CD tooling that blocks merge until a spec has the appropriate fields and structure 👀 Like no merging a spec with |
I think there should definitely be an |
This is a GREAT idea. I hope you are documenting all of these in the Specture repo. It would also be cool to have tooling that lists all of the contributors to a spec. Git should make this easy under the hood, something like |
Fair. My one fear was two people working on implementing the same spec in parallel. But really that shouldn't be a big deal. Good team communication will avoid it and even if you do end up with two implementations that's not really a bad thing. You can combine the best of both and end up better for it. |
Yes that is what I meant, sorry. And maybe also |
|
Oops push initially failed. Everything should be up now. |
|
Suggestion: use |
Changes
specs/directory with my current todo list for the project. These will definitely be revised with time as I figure out what I'm doing.CONTRIBUTING.mdandAGENTS.md.specs/README.mdexplaining Specture