Harden registration system: XSS-safe DOM, email normalization, instanceof guard#3
Merged
mrobardsKO merged 2 commits intoaccelerate-with-copilotfrom Mar 4, 2026
Merged
Conversation
…alization in app.py Co-authored-by: mrobardsKO <113369208+mrobardsKO@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Improve student activity registration system
Harden registration system: XSS-safe DOM, email normalization, instanceof guard
Mar 4, 2026
mrobardsKO
approved these changes
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses three security/correctness issues flagged in review: unsafe HTML interpolation in the activity card renderer, missing type guard before
closest(), and email inputs accepted without normalization (enabling duplicate-bypass via case or whitespace).Changes
src/static/app.jsinnerHTMLstring interpolation with DOM API construction (createElement,textContent,dataset) throughout the activity card renderer — eliminates stored XSS and attribute injection vectorsinstanceof Elementguard onevent.targetbefore calling.closest()in the unregister click handlersrc/app.pyemailwith.strip().lower()in bothsignup_for_activityandunregister_from_activitybefore membership checks or storage, preventing case/whitespace bypasstests/test_app.py💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.