Open
Conversation
…constructed from a size_t in e.e.g. memset_loc, and then converted back to a size_t in the Kokkos RangePolicy, and bad things happen
…big flat loop, and add same adjustments to FArray
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Otherwise, this is an int implictly constructed from a size_t in e.g. memset_loc, and then converted back to a size_t in the Kokkos RangePolicy. This results in RangePolicy throwing (e.g.
Kokkos::RangePolicy bound type error: an unsafe implicit conversion is performed on a bound (18446744071830503424), which may not preserve its original value.).This necessitates some changes in loop handling, but they couldn't handle more than int32 number of iterations (but e.g. in cuda we could do 2^31-1 * BlockSize (e.g. 128)). I think for multi-dimensional loops int32 is fine per dimension, but for things like
memset_loc, that implicitly flatten, this is a problem. So I've tweaked the code to work around this.