fix: MODULE.bazel.lock inconsistency across platforms #28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes issue mrmeku#27 where MODULE.bazel.lock would differ between Linux and macOS due to platform-specific CLI binary watching. Root cause: The code was only watching the current platform's CLI binary (e.g., cli-x86_64-unknown-linux-musl on Linux or cli-arm64-apple-darwin on macOS), causing the lockfile to record different file inputs depending on which platform ran 'bazel mod deps'. Solution: Watch all platform-specific CLI binaries instead of just the current platform's binary. This ensures MODULE.bazel.lock records all four binaries consistently across platforms. This approach is necessary because: - The CLI binaries are checked into source control - They need to be watched to detect when they're updated - All platforms must watch the same set of files for lockfile consistency - A platform-independent marker file doesn't exist yet Changes: - Added get_all_cli_paths() to util.bzl to return all CLI binary paths - Updated extensions.bzl to watch all CLI paths in module extension - Updated repositories.bzl to watch all CLI paths in repository rules
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I asked Claude to fix #27 and Claude produced this. It seems reasonable to me, and does appear to fix the issue. Rather than only watching the cli on the platform that we are currently using, this watches the cli on all possible platform settings.
Closes #27