Wrap the Logger outputs from DNS strategy in conditional#23
Open
ddresselhaus wants to merge 1 commit intomrluc:masterfrom
Open
Wrap the Logger outputs from DNS strategy in conditional#23ddresselhaus wants to merge 1 commit intomrluc:masterfrom
ddresselhaus wants to merge 1 commit intomrluc:masterfrom
Conversation
ddresselhaus
force-pushed
the
wrap_dns_logger_in_conditional
branch
from
d3749b8 to
5b50f9c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using the DNS strategy, I'm still getting debug statements even with the log_results config set to false.
So I've wrapped the DNS logger statements in a conditional, checking the
log_resultsconfig.