render chunks faster #386
Merged
render chunks faster #386
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Did you measure concrete gains? Like "Previous code took X ms to render N chunks, this code takes Y ms"? |
EtlamGit
reviewed
Oct 20, 2025
|
|
||
| QMap<qint8, ChunkSection*> sections; | ||
| QVector<ChunkSection*> sections; | ||
| int lowestSection; // this allows a "bias" for the sections vector since we want negative indices |
Collaborator
There was a problem hiding this comment.
qint8 (=char) would be enough, but probably the compiler will not save anything then.
EtlamGit
reviewed
Oct 20, 2025
| it.previous(); | ||
| if (it.value()) { | ||
| for (int i = this->sections.size() - 1; i >= 0; --i) { | ||
| auto cs = this->sections.at(i); |
Collaborator
There was a problem hiding this comment.
Which type does auto generate here?
I would use: const ChunkSection*
EtlamGit
reviewed
Oct 20, 2025
Collaborator
EtlamGit
left a comment
EtlamGit
left a comment
There was a problem hiding this comment.
Looks ok for me.
I would also be interested in the performance gain we get with this.
Contributor
Author
|
Don't know an easy way to benchmark the ChunkRender, unfortunately this doesn't directly improve the UI FPS that much: the worker threads spend most of their time idle since the Qt signals are have high latency and rendering a single chunk is very fast. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses #385 and another hotspot I saw during rendering, but now it appears to be bottlenecked on the speed of the multithreaded work dispatching-- I am not saturating all cores during rendering.