Skip to content

Improve dialog UX #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SayHeyD wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Improve dialog UX #2

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2cd189c
Focus confirmation window after prompt is shown
Jan 15, 2025
4dbae92
Always open dialog in current application and play notification sound
Jan 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions ssh-askpass
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,8 @@ set -o nounset
# exit if one command in a pipeline fails
set -o pipefail

SOUND="/System/Library/Sounds/Tink.aiff"

# check if paused for 1 minute
if [ -e '/tmp/disable-askpass' ]
then
Expand All @@ -23,9 +25,14 @@ then

fi

# create dialog window
# create dialog window and play sound
sleep 0.1 && afplay "$SOUND" & \
result=$(osascript \
-e 'tell application "Terminal"' \
-e "tell application \"System Events\"" \
-e "set frontmostProcess to first process where it is frontmost" \
-e "set appName to name of frontmostProcess" \
-e "end tell" \
-e "tell application appName" \
-e "display dialog \"$*\" buttons {\"Deny\", \"Allow for 1min\", \"Allow\"} default button 3 with title \"SSH Agent\" with icon caution" \
-e 'end tell')

Expand Down