Use TTM EPS instead of the most recent year (#97) #98
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PBT for NVDA: - Before: 17 years, - After: 13 years.
Error was:
```
File "isthisstockgood/Active/MSNMoney.py", line 116, in parse_ratios_data
self.last_year_net_income = sum(self.quarterly_eps[-4:]) \
TypeError: can't multiply sequence by non-int of type 'float'
```
The problem here was: how is the result of `sum()` a "sequence"?
kocielnik
changed the title
kocielnik
changed the title
kocielnik
changed the title
Contributor
Author
|
@mrhappyasthma, please let me know if I could help merge this in any way. Thanks! :) |
Owner
|
Sorry been busy. This LGTM and is a nice improvement. |
Owner
|
This should now be deployed. |
Contributor
Author
|
No problem, thanks for merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Live preview at https://isthisstockgood.vercel.app
PBT(NVDA) before = 17 years
PBT(NVDA) after = 13 years