Fix MOSP: Use Zacks for growth estimates (closes #91). #92
Conversation
kocielnik
force-pushed
the
master
branch
2 times, most recently
from
8ae4c82 to
56dcb5e
Compare
|
@mrhappyasthma, ready now, feel free to take a look:) |
I expect the breaking of this test to be fixed by PR mrhappyasthma#92.
* Add 10Cap valuation (closes #88). * Delete the test that is not relevant anymore. I expect the breaking of this test to be fixed by PR #92. * Fix div id. * Make the test test the *API*, not NVDA:) Actually, the purpose of this commit is to bump the CI to run again, because it failed with an error that seems intermittent, and very rare. * Fix precision of 10Cap price. Before: ten_cap("NVDA") = 10.834 After: ten_cap("NVDA") = 10.83
|
|
||
| data = json.loads(res.text) | ||
| assert data['debt_payoff_time'] == 0 | ||
| assert data['sticker_price'] > 0.0 |
There was a problem hiding this comment.
This line and the next one verify that each valuation method still works.
|
|
||
| def parse_json_data(self, data): | ||
| try: | ||
| print(data) |
There was a problem hiding this comment.
Yeah, that's unrelated to the issue:)
|
Resolved the conflicts. Feel free to take a look again, @mrhappyasthma! :) |
kocielnik
changed the title
|
Done:
@mrhappyasthma, please let me know if I can help in any other way:) |
|
I'll try to take a pass on this ASAP. Been busy with the holidays and such. |
|
Sure, thanks! |
In case it returns in the future (CR).
On no data from Yahoo Finance, use the estimate from Zacks.
|
Thanks for the comments, @mrhappyasthma! I believe I've applied all your suggestions. Please let me know what you think! |
|
The preview at https://isthisstockgood.vercel.app/ uses the updated code now. |
|
Thanks again for all the help. Will deploy now |
|
You're welcome! Thank you for keeping this tool useful and maintainable! |
2 participants
I got very conservative estimates for the stocks I tried.
Probably this is still much better than nothing:)