Conversation
Refactor Runnable trait implementations and related code to return Arc<dyn ProcessControlHandler> instead of Box<dyn ProcessControlHandler> for improved shared ownership and consistency across the codebase.
receiver Refactor ProcessManager PID initialization and add manual/auto cleanup constructors Add Custom variant to RuntimeControlMessage for future extensibility
- Add lock-free shutdown flag and notification for efficient shutdown waiting - Implement fan-out task to forward control messages to a single RuntimeTicker - Provide ProcessControlHandler implementation for RuntimeGuard handle - Simplify RuntimeTicker creation and sender cloning - Add Clone impl for RuntimeControlMessage with panic for unsupported Custom variant
- Simplify RuntimeGuard internals with tokio Mutex and async-friendly channels - Change RuntimeTicker to return sender and use async Mutex for receiver - Use Cow<'static, str> for process_name implementations - Remove unused internal state and streamline control message forwarding task
Set up Rust CI with build, formatting, linting, and tests across stable, beta, and nightly toolchains. Add CHANGELOG.md with Keep-a-Changelog format.
Introduce a fluent builder to configure ProcessManager upfront, eliminating "wrong phase" panics and enabling compile-time safety when registering child processes before starting the manager.
Deprecate ProcessManager constructors in favor of the builder API. Migrate examples and tests to use ProcessManagerBuilder for setup.
Wrap process_start future with tracing::Instrument to attach a span instead of entering it directly, enabling better async tracing support.
Introduce IdleProcess, a no-op Runnable that idles until shutdown, useful as a tombstone child to keep ProcessManager running without real children. Move SignalReceiver to builtin and deprecate old receiver module.
- Store JoinHandle for each child process to monitor and abort if needed - Improve shutdown logic to timeout after 30 seconds per child - Add detailed logging on process start, stop, shutdown, and timeout events - Enforce add() can only be called when manager is running - Use JoinSet to await all shutdown futures concurrently
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.