Add modal route to did change dependencies#10
Open
march93 wants to merge 1 commit intomrahimygk:masterfrom
Open
Add modal route to did change dependencies#10march93 wants to merge 1 commit intomrahimygk:masterfrom
march93 wants to merge 1 commit intomrahimygk:masterfrom
Conversation
Owner
|
If the booleans like (hasParsedArgs) is not needed any more by this change, please remove them. |
Author
|
I'm not quite sure what you mean by that, it looks like that boolean still has a purpose somewhere in the code but this change didn't affect it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moved modal route into
didChangeDependenciesin add notes page.Issue #5