Skip to content

Conversation

@mrMigles
Copy link
Owner

@mrMigles mrMigles commented Jan 5, 2026

Summary

  • configure Maven build to target Java 21 via updated compiler settings
  • switch Docker base image to a Java 21 runtime
  • tidy build script output formatting

Testing

  • java -version
  • ./mvnw -version (fails: network is unreachable while downloading Maven wrapper distribution)

Codex Task

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 31ee460a0a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines 199 to 203
<artifactId>maven-compiler-plugin</artifactId>
<version>3.11.0</version>
<configuration>
<release>21</release>
</configuration>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Add javax.annotation-api for Java 21 build

Switching the compiler target to Java 21 (maven-compiler-plugin release 21) means the build now runs on a JDK that no longer ships javax.annotation (removed with the old Java EE modules). The codebase still imports javax.annotation.PostConstruct/Nonnull in multiple classes (e.g., src/main/java/ru/holyway/botplatform/BotPlatformApplication.java:13), and the POM does not declare a javax.annotation-api dependency, so compilation on Java 21 will fail with “package javax.annotation does not exist.” Please add the API dependency or keep targeting a JDK that provides it.

Useful? React with 👍 / 👎.

@mrMigles mrMigles merged commit fdc80cb into master Jan 5, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants