-
Notifications
You must be signed in to change notification settings - Fork 0
Update project for Java 21 #25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 31ee460a0a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| <artifactId>maven-compiler-plugin</artifactId> | ||
| <version>3.11.0</version> | ||
| <configuration> | ||
| <release>21</release> | ||
| </configuration> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add javax.annotation-api for Java 21 build
Switching the compiler target to Java 21 (maven-compiler-plugin release 21) means the build now runs on a JDK that no longer ships javax.annotation (removed with the old Java EE modules). The codebase still imports javax.annotation.PostConstruct/Nonnull in multiple classes (e.g., src/main/java/ru/holyway/botplatform/BotPlatformApplication.java:13), and the POM does not declare a javax.annotation-api dependency, so compilation on Java 21 will fail with “package javax.annotation does not exist.” Please add the API dependency or keep targeting a JDK that provides it.
Useful? React with 👍 / 👎.
Summary
Testing
java -version./mvnw -version(fails: network is unreachable while downloading Maven wrapper distribution)Codex Task