Skip to content

Conversation

@mrMigles
Copy link
Owner

Summary

  • add structured script registry/context factory and improve compiler logging
  • replace ad-hoc stdout usage with SLF4J and extend test coverage for scripting utilities
  • document and configure GitHub Actions workflow to build and deploy to Portainer

Testing

  • mvn test (fails: dependency resolution blocked for spring-boot-starter-parent)

Codex Task

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines 33 to 36
public void compileShouldWrapGroovyErrors() {
expectedException.expect(ScriptCompilationException.class);
expectedException.expectMessage(is("Unable to compile script"));
expectedException.expectMessage(containsString("badMethod"));

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Fix impossible ScriptCompiler error expectations

compileShouldWrapGroovyErrors asks the exception message to both equal "Unable to compile script" and also contain "badMethod". A string cannot satisfy both matchers at once, so this test will fail every run even if the compiler correctly wraps Groovy errors, breaking the suite. Align the expected message (or the thrown text) so the matchers are consistent.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants