feat(gui): add CalibrationResultsDisplay and promote dev view to widget #911
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a CalibrationResultsDisplay widget that shows camera matrix parameters, distortion coefficients, and fit quality metrics. The results panel is always visible with placeholder values until calibration populates them. Restructure the layout to horizontal (side-by-side): - Left: Results panel (always visible) - Right: Video display + controls This eliminates jumping UI elements for better UX. Rename intrinsic_calibration_dev_view.py to intrinsic_calibration_widget.py and update class name accordingly. Closes #892 Closes #883 Refs #869, #870
The test was using qsize() to drain the queue, but Python docs warn this is unreliable in multithreaded contexts. This caused flaky failures on macOS CI where a stale packet could arrive after the drain check but before the seek. - Use timeout-based drain instead of qsize() check - Loop until we receive the expected frame_index after seek, discarding any stale packets from before pause took full effect Refs #892
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
CalibrationResultsDisplaywidget showing camera matrix, distortion coefficients, and fit quality metricsintrinsic_calibration_dev_view.py→intrinsic_calibration_widget.pyChanges
CalibrationResultsDisplay (~100 lines):
—) until calibrationupdate_from_camera()populates from CameraDatareset()clears back to placeholders on recalibrateLayout restructure:
Test Plan
basedpyright)Closes #892
Closes #883
Refs #869, #870