feat(recording): create FramePacketPublisher #896
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace RecordedStream with a cleaner separation of concerns: - FrameTimestamps: immutable timing mapping (frame_index -> timestamp) - FramePacketPublisher: streaming layer with pub/sub, threading, tracking Key changes: - FrameSource constructor now takes (video_directory, port) instead of path - create_publisher() factory handles FrameSource + FrameTimestamps creation - Thread-safe subscriber management with Condition-based waiting - Playback control (pause/unpause, seeking) built-in Also fixes flaky test_cancel_emits_cancelled_signal by adding proper synchronization with start_event pattern. Refs #889
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
RecordedStreamwith cleaner separation:FrameTimestamps(timing) +FramePacketPublisher(streaming)FrameSourceconstructor now takes(video_directory, port)instead of raw pathTest plan
test_synchronizerpasses (was hanging)test_sync_stream_managerpasses (was hanging)test_stream.pyupdated for new publisher APItest_frame_source.pyupdated for new constructorCloses #889