fix(export): carry frame_time through pipeline for TRC export #878
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frame_time was discarded during triangulation, causing TRC export to fail with NaN errors when gap-filled xyz data had sync_indices not present in frame_time_history.csv. Changes: - Add frame_time to WorldPointSchema (nullable for legacy paths) - Carry frame_time through triangulate() by computing mean per sync_index - Interpolate frame_time in WorldPoints.fill_gaps() - Update xyz_to_trc() to use frame_time from xyz data directly - Add integration test with gap-fill disparity logging Fixes #877
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
ValueError: cannot convert float NaN to integerwhen gap-filled xyz data has sync_indices not present inframe_time_history.csvframe_timethrough the triangulation pipeline instead of relying on external file lookupChanges
frame_timetoWorldPointSchema(nullable), carry throughtriangulate(), interpolate infill_gaps()time_history_pathparam fromxyz_to_trc(), useframe_timefrom xyz DataFramexyz_to_trc()calltest_gap_fill_pipeline_accuracy()with disparity loggingTest plan
Fixes #877