Added shift+M without having to press space first (Issue #49)#53
Added shift+M without having to press space first (Issue #49)#53MimmyJau wants to merge 1 commit intompereira:masterfrom
Conversation
|
Hi @MimmyJau, Thanks for this feature, I think it makes a lot of sense! As you mentioned, the current implementation for it might not be in its simplest form. The existing game implementation itself doesn't help, since it expected movements to start by marking cards with the spacebar. I'll try to think about a cleaner way to implement this during this weekend. It might require refactoring the existing keyboard handling a bit to better accommodate card movements not starting with the spacebar. If you have ideas feel free to share them too. In addition to that, when we get |
|
Thanks @mpereira, I'll spend some time thinking about it too. If you come up with something and want some help implementing it, let me know. And agree on having an unselect all cards stack. As I was playing the game with this patch, I realized |
Can now <Shift+M> without having to press space first. I was trying to prioritize adding as little code as possible, so solution might not be the cleanest. I find the feature useful when I play personally.
Very open to any and all feedback. Addresses Issue #49.