Added wraparound navigation (Issue #50)#52
Open
MimmyJau wants to merge 2 commits intompereira:masterfrom
Open
Conversation
MimmyJau
changed the title
greno4ka
suggested changes
Nov 21, 2020
Contributor
greno4ka
left a comment
greno4ka
left a comment
There was a problem hiding this comment.
This is a bad patch, because you duplicate code about moving cursor up and down.
Owner
|
I'm not sure about this one, I personally like having the extremities being "physical limits", so I can press I'll think about it. |
Contributor
I think it can be discussed in issue #50. |
Contributor
Author
Good call. I made the changes in the event we decide to use this. Let me know if I understood correctly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add feature that lets you press left button at left-most stack to loop cursor around to right-most stack (and vice-versa). Related to Issue #50. I find it helpful personally when I play.
First pull request so welcome any feedback.