Draw a beautiful 'You won!' window#22
Open
greno4ka wants to merge 1 commit intompereira:masterfrom
greno4ka:winwindow
Open
Draw a beautiful 'You won!' window#22greno4ka wants to merge 1 commit intompereira:masterfrom greno4ka:winwindow
greno4ka wants to merge 1 commit intompereira:masterfrom
greno4ka:winwindow
Conversation
Owner
|
What do you think about drawing a message on top of the game screen? |
Contributor
Author
|
I drawed it in the center of 25x80 screen. You can place it wherever you want! |
Owner
|
I meant with the deck still showing below the message, so that the player can still see the game state. |
Contributor
Author
|
I think you should just remove content of 103 line in that file=) But this should be done carefully, to save the beauty of the program. I can check, how this idea will look like. |
Contributor
Author
|
Without detecting win situation: If you want to know my opinion: I think text on clear green window looks better! |
mpereira
force-pushed
the
master
branch
3 times, most recently
from
c878544 to
e08cb0f
Compare
Contributor
Author
|
So what? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I make a little improvement of your game. Tested. Looks like this.
Look at it some evening, and merge, if you like it=)