-
Notifications
You must be signed in to change notification settings - Fork 6
Add performers field to songs #16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
DamienCassou
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for decomposing your PR. Can you please have a look at my feedback? Is there anything to update in the README?
|
and as to the readme: This does not introduce any new data types, and since many of the fields of |
DamienCassou
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. Can we add a unit test or two?
As for #17, please sign your commits if you can.
DamienCassou
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent. Do you plan to sign your commits or should I move forward without?
|
I plan to sign them, just have to figure out how to set that up |
you may want to read this: https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits |
|
Thanks for the link, I signed the commits |
DamienCassou
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent! Thank you
No description provided.