-
Notifications
You must be signed in to change notification settings - Fork 67
Add support for local development with Docker #178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
25ff19d to
e73ab7f
Compare
|
@atombrella I recently updated most of the package version dependencies. Do you have any interest in testing out the current codebase? |
Yes, I'll try :) |
e73ab7f to
6b6ad24
Compare
|
@gstrauss I updated it to use Node 22, and it runs smoothly. My branch is open for edits from repository maintainers. I don't know why the NodeJS Alpine based base image cannot be used. It fails with : Can the draft mode be removed? |
My guess is that the |
|
Why does the RUN command explicitly install copy-webpack-plugin and webpack-cli? Why not simply |
|
@gstrauss I've updated it, and the missing git as the reason why Alpine didn't work. |
|
@atombrella Thank you. I am going to check with others for some input, but expect to resolve this PR before the end of January (and hopefully much sooner). |
5958374 to
a646f4e
Compare
a646f4e to
b799329
Compare
|
LGTM! Thank you for your contribution! (and thank you for your patience) |
All the node dependencies can clutter your local machine, and you may need different versions of node installed.
The Dockerfile was mainly inspired by the official documentation for NodeJS. https://nodejs.org/en/docs/guides/nodejs-docker-webapp/
Please be aware that there are several dependencies which are listed with
npm audit. I'm not sure how much bandwidth you have for this project, but I'd suggest adding dependabot to the project.