Skip to content

Conversation

@badboy
Copy link
Member

@badboy badboy commented Dec 18, 2025

This is #969 again.
In #977 we reverted that due to issues on deployment.

@badboy
Copy link
Member Author

badboy commented Dec 19, 2025

python3 -m probe_scraper.runner --dry-run --cache-dir tmp/cache --out-dir tmp/out --glean --glean-limit-date 2025-12-16 --output-bucket=gs://probe-scraper-prod-artifacts/ --glean-url https://github.com/mozilla-firefox/firefox

is enough to trigger the dupe check.
My previous dry-run uses --glean-repo gecko and I thought that would include the other apps as well (because it's the same repo), but no.

@badboy
Copy link
Member Author

badboy commented Dec 19, 2025

The duplications are currently real. Things are clashing between crashping and lib-crash.
I should have paid more attention.
https://phabricator.services.mozilla.com/D265514 has not yet landed. That's the one actually removing the metrics from lib-crash (in mobile/android/android-components/components/lib/crash/metrics.yaml), making the definition in crashping the only one.
If that lands and THEN we update probe-scraper it should work I think.I will check that.
Alternatively we can use the SKIP_METRICS hack to exclude all those metrics. That should be fine because code-wise (a) the metrics are the same, just moved, (b) they will only ever either be sent from lib-crash or crashping, never both libraries.

@badboy
Copy link
Member Author

badboy commented Dec 23, 2025

I have applied D265514, the commit that removes the old files (pushed into my firefox fork).
I have then modified repositories.yaml to point to that (5497b48c6a7e0798ba66a24f13a9d7d2b407fd5d) and ran this dry-run:

python3 -m probe_scraper.runner --dry-run --cache-dir tmp/cache --out-dir tmp/out --glean --glean-limit-date 2025-12-16 --output-bucket=gs://probe-scraper-prod-artifacts/ --glean-url https://github.com/badboy/firefox

This succeeds without issues. No duplicates detected, as expected.


When we're back in January we should be able to land this:

  1. Land the patch set in m-c that includes removing the old files.
  2. Land this probe-scraper change
  3. Trigger the probe-scraper run & schema generation (we can do this during work hours to verify everything is correct)

If the patch set in m-c lands without us merging this soon after the probe-scraper run will fail and complain (and send angry emails). Other than nuisance that's ok though, nothing breaks. But we also have near 'round-the-clock coverage and can ensure things land in timely fashion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants