Start using Response.prototype.bytes() in the code-base
#20651
Conversation
In all cases where we currently use `Response.prototype.arrayBuffer()` the result is immediately wrapped in a `Uint8Array`, which can be avoided by instead using the newer `Response.prototype.bytes()` method; see https://developer.mozilla.org/en-US/docs/Web/API/Response/bytes
…unction After the previous patch there's no longer any call-site using that type.
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/4dcb5353aadad9a/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/5ec1fcbb48cb860/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/4dcb5353aadad9a/output.txt Total script time: 60.00 mins |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/5ec1fcbb48cb860/output.txt Total script time: 83.46 mins
Image differences available at: http://54.193.163.58:8877/5ec1fcbb48cb860/reftest-analyzer.html#web=eq.log |
|
/botio-linux test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/e0d57d12799c17a/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/e0d57d12799c17a/output.txt Total script time: 60.00 mins |
timvandermeij
left a comment
timvandermeij
left a comment
There was a problem hiding this comment.
Looks good to me; thanks!
|
/botio-linux test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/f59cf6dc97c193d/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/f59cf6dc97c193d/output.txt Total script time: 41.40 mins
Image differences available at: http://54.241.84.105:8877/f59cf6dc97c193d/reftest-analyzer.html#web=eq.log |
4 participants
In all cases where we currently use
Response.prototype.arrayBuffer()the result is immediately wrapped in aUint8Array, which can be avoided by instead using the newerResponse.prototype.bytes()method; see https://developer.mozilla.org/en-US/docs/Web/API/Response/bytes