Skip to content

Convert PDFPageProxy.prototype.getTextContent to an asynchronous method #20648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
calixteman merged 1 commit into from
Feb 12, 2026
Merged

Convert PDFPageProxy.prototype.getTextContent to an asynchronous method #20648

calixteman merged 1 commit into from
Feb 12, 2026
+12 −22

Conversation

@Snuffleupagus
Copy link
Collaborator

@Snuffleupagus Snuffleupagus commented Feb 11, 2026

This is a tiny bit shorter, which cannot hurt.

@Snuffleupagus
Copy link
Collaborator Author

Snuffleupagus commented Feb 11, 2026

/botio test

nicolo-ribaudo
nicolo-ribaudo reviewed Feb 11, 2026
View reviewed changes
@Snuffleupagus
Convert PDFPageProxy.prototype.getTextContent to an asynchronous me…
c1b824f 
…thod

This is a tiny bit shorter, which cannot hurt.
@Snuffleupagus Snuffleupagus force-pushed the api-async-getTextContent branch from 39446a2 to c1b824f Compare February 11, 2026 18:52
@mozilla mozilla deleted a comment from moz-tools-bot Feb 11, 2026
@mozilla mozilla deleted a comment from moz-tools-bot Feb 11, 2026
@mozilla mozilla deleted a comment from moz-tools-bot Feb 11, 2026
@mozilla mozilla deleted a comment from moz-tools-bot Feb 11, 2026
@Snuffleupagus
Copy link
Collaborator Author

Snuffleupagus commented Feb 11, 2026

/botio test

@moz-tools-bot
Copy link
Collaborator

moz-tools-bot commented Feb 11, 2026

From: Bot.io (Linux m4)

Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/b92d459f556cc09/output.txt

@moz-tools-bot
Copy link
Collaborator

moz-tools-bot commented Feb 11, 2026

From: Bot.io (Windows)

Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/a033c7763224652/output.txt

@moz-tools-bot
Copy link
Collaborator

moz-tools-bot commented Feb 11, 2026

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/a033c7763224652/output.txt

Total script time: 8.88 mins

  • Unit tests: FAILED
  • Integration Tests: FAILED
  • Regression tests: FAILED

Image differences available at: http://54.193.163.58:8877/a033c7763224652/reftest-analyzer.html#web=eq.log

@moz-tools-bot
Copy link
Collaborator

moz-tools-bot commented Feb 11, 2026

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/b92d459f556cc09/output.txt

Total script time: 41.80 mins

  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 1

Image differences available at: http://54.241.84.105:8877/b92d459f556cc09/reftest-analyzer.html#web=eq.log

@Snuffleupagus
Copy link
Collaborator Author

Snuffleupagus commented Feb 11, 2026

/botio-windows test

@moz-tools-bot
Copy link
Collaborator

moz-tools-bot commented Feb 11, 2026

From: Bot.io (Windows)

Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/cc4949889f6598e/output.txt

@moz-tools-bot
Copy link
Collaborator

moz-tools-bot commented Feb 11, 2026

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/cc4949889f6598e/output.txt

Total script time: 83.07 mins

  • Unit tests: FAILED
  • Integration Tests: FAILED
  • Regression tests: FAILED
  different ref/snapshot: 1

Image differences available at: http://54.193.163.58:8877/cc4949889f6598e/reftest-analyzer.html#web=eq.log

calixteman
calixteman approved these changes Feb 12, 2026
View reviewed changes
Copy link
Contributor

@calixteman calixteman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you.

@calixteman calixteman merged commit f24768d into mozilla:master Feb 12, 2026
11 checks passed
@Snuffleupagus Snuffleupagus deleted the api-async-getTextContent branch February 12, 2026 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@calixteman calixteman calixteman approved these changes

+1 more reviewer

@nicolo-ribaudo nicolo-ribaudo nicolo-ribaudo approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

core

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Snuffleupagus @moz-tools-bot @calixteman @nicolo-ribaudo