Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/display/annotation_layer.js
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,10 @@
/** @typedef {import("../../web/struct_tree_layer_builder.js").StructTreeLayerBuilder} StructTreeLayerBuilder */
// eslint-disable-next-line max-len
/** @typedef {import("../../web/comment_manager.js").CommentManager} CommentManager */
// eslint-disable-next-line max-len
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If npx gulp typestest passes again with these changes, please also undo the change from aa4d0f7 in the scope of this MR to activate it again in the CI.

/** @typedef {import("../../web/pdf_link_service.js").PDFLinkService} PDFLinkService */
// eslint-disable-next-line max-len
/** @typedef {import("../../web/base_download_manager.js").BaseDownloadManager} BaseDownloadManager */

import {
AnnotationBorderStyleType,
Expand Down
1 change: 1 addition & 0 deletions src/display/editor/annotation_editor_layer.js
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
/** @typedef {import("../draw_layer.js").DrawLayer} DrawLayer */
// eslint-disable-next-line max-len
/** @typedef {import("../src/display/struct_tree_layer_builder.js").StructTreeLayerBuilder} StructTreeLayerBuilder */
/** @typedef {import("../../../web/l10n.js").L10n} L10n */
Comment on lines 25 to +26
Copy link
Contributor

@timvandermeij timvandermeij Feb 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The line above this one points to ../src/display/struct_tree_layer_builder.js but there is no src folder in the top-level folder that .. refers to, and the struct tree builder lives in the web/ folder instead. I assume that one is incorrect, and should be ../../../web/struct_tree_layer_builder.js instead?


import {
AnnotationEditorPrefix,
Expand Down
2 changes: 2 additions & 0 deletions src/display/xfa_layer.js
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@
// eslint-disable-next-line max-len
/** @typedef {import("./annotation_storage").AnnotationStorage} AnnotationStorage */
/** @typedef {import("./display_utils").PageViewport} PageViewport */
// eslint-disable-next-line max-len
/** @typedef {import("../../web/pdf_link_service.js").PDFLinkService} PDFLinkService */

import { XfaText } from "./xfa_text.js";

Expand Down
3 changes: 3 additions & 0 deletions web/annotation_layer_builder.js
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,9 @@
// eslint-disable-next-line max-len
/** @typedef {import("../src/display/editor/tools.js").AnnotationEditorUIManager} AnnotationEditorUIManager */
/** @typedef {import("./comment_manager.js").CommentManager} CommentManager */
/** @typedef {import("./pdf_link_service.js").PDFLinkService} PDFLinkService */
// eslint-disable-next-line max-len
/** @typedef {import("./base_download_manager.js").BaseDownloadManager} BaseDownloadManager */

import {
AnnotationLayer,
Expand Down
1 change: 1 addition & 0 deletions web/pdf_find_controller.js
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@

/** @typedef {import("../src/display/api").PDFDocumentProxy} PDFDocumentProxy */
/** @typedef {import("./event_utils").EventBus} EventBus */
/** @typedef {import("./pdf_link_service.js").PDFLinkService} PDFLinkService */

import { binarySearchFirstItem, scrollIntoView } from "./ui_utils.js";
import { getCharacterType, getNormalizeWithNFKC } from "./pdf_find_utils.js";
Expand Down
1 change: 1 addition & 0 deletions web/pdf_history.js
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
*/

/** @typedef {import("./event_utils").EventBus} EventBus */
/** @typedef {import("./pdf_link_service.js").PDFLinkService} PDFLinkService */

import { isValidRotation, parseQueryString } from "./ui_utils.js";
import { updateUrlHash } from "pdfjs-lib";
Expand Down
1 change: 1 addition & 0 deletions web/pdf_page_view.js
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
// eslint-disable-next-line max-len
/** @typedef {import("./pdf_rendering_queue").PDFRenderingQueue} PDFRenderingQueue */
/** @typedef {import("./comment_manager.js").CommentManager} CommentManager */
/** @typedef {import("./l10n.js").L10n} L10n */

import {
AbortException,
Expand Down
1 change: 1 addition & 0 deletions web/pdf_rendering_queue.js
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
/** @typedef {import("./pdf_viewer").PDFViewer} PDFViewer */
// eslint-disable-next-line max-len
/** @typedef {import("./pdf_thumbnail_viewer").PDFThumbnailViewer} PDFThumbnailViewer */
/** @typedef {import("./renderable_view").RenderableView} RenderableView */

import { RenderingCancelledException } from "pdfjs-lib";
import { RenderingStates } from "./renderable_view.js";
Expand Down
1 change: 1 addition & 0 deletions web/pdf_thumbnail_viewer.js
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
/** @typedef {import("./event_utils").EventBus} EventBus */
// eslint-disable-next-line max-len
/** @typedef {import("./pdf_rendering_queue").PDFRenderingQueue} PDFRenderingQueue */
/** @typedef {import("./pdf_link_service.js").PDFLinkService} PDFLinkService */

import {
binarySearchFirstItem,
Expand Down
4 changes: 4 additions & 0 deletions web/pdf_viewer.js
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,10 @@
/** @typedef {import("./pdf_find_controller").PDFFindController} PDFFindController */
// eslint-disable-next-line max-len
/** @typedef {import("./pdf_scripting_manager").PDFScriptingManager} PDFScriptingManager */
/** @typedef {import("./pdf_link_service.js").PDFLinkService} PDFLinkService */
// eslint-disable-next-line max-len
/** @typedef {import("./base_download_manager.js").BaseDownloadManager} BaseDownloadManager */
/** @typedef {import("./l10n.js").L10n} L10n */

import {
AnnotationEditorType,
Expand Down
6 changes: 3 additions & 3 deletions web/renderable_view.js
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ class RenderableView {
renderingId = "";

/**
* @type {RenderTask | null}
* @type {import("../src/display/api").RenderTask | null}
*/
renderTask = null;

Expand All @@ -47,14 +47,14 @@ class RenderableView {
}

/**
* @type {RenderingStates}
* @type {number}
*/
get renderingState() {
throw new Error("Abstract getter `renderingState` accessed");
}

/**
* @param {RenderingStates}
* @param {number} state
*/
set renderingState(state) {
throw new Error("Abstract setter `renderingState` accessed");
Expand Down
1 change: 1 addition & 0 deletions web/xfa_layer_builder.js
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
/** @typedef {import("../src/display/annotation_storage").AnnotationStorage} AnnotationStorage */
// eslint-disable-next-line max-len
/** @typedef {import("../src/display/display_utils").PageViewport} PageViewport */
/** @typedef {import("./pdf_link_service.js").PDFLinkService} PDFLinkService */

import { XfaLayer } from "pdfjs-lib";

Expand Down