Skip to content

Set a pages mapper per loaded document #20640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
calixteman merged 1 commit into from
Feb 9, 2026
Merged

Set a pages mapper per loaded document #20640

calixteman merged 1 commit into from
Feb 9, 2026

Conversation

@calixteman
Copy link
Contributor

@calixteman calixteman commented Feb 8, 2026

It fixes #20629.

@calixteman
Copy link
Contributor Author

calixteman commented Feb 8, 2026

/botio integrationtest

@moz-tools-bot
Copy link
Collaborator

moz-tools-bot commented Feb 8, 2026

From: Bot.io (Linux m4)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 2

Live output at: http://54.241.84.105:8877/45c484c4fc952b5/output.txt

@moz-tools-bot
Copy link
Collaborator

moz-tools-bot commented Feb 8, 2026

From: Bot.io (Windows)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 2

Live output at: http://54.193.163.58:8877/0a894ab36258498/output.txt

timvandermeij
timvandermeij approved these changes Feb 8, 2026
View reviewed changes
Copy link
Contributor

@timvandermeij timvandermeij left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me, with the comment addressed and passing tests. Thank you for fixing this!

@moz-tools-bot
Copy link
Collaborator

moz-tools-bot commented Feb 8, 2026

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/45c484c4fc952b5/output.txt

Total script time: 22.66 mins

  • Integration Tests: FAILED

@calixteman
Copy link
Contributor Author

calixteman commented Feb 9, 2026

/botio integrationtest

@moz-tools-bot
Copy link
Collaborator

moz-tools-bot commented Feb 9, 2026

From: Bot.io (Windows)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/1bdf305543a9a37/output.txt

@moz-tools-bot
Copy link
Collaborator

moz-tools-bot commented Feb 9, 2026

From: Bot.io (Linux m4)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/e948c87fb52a24e/output.txt

@moz-tools-bot
Copy link
Collaborator

moz-tools-bot commented Feb 9, 2026

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/e948c87fb52a24e/output.txt

Total script time: 21.85 mins

  • Integration Tests: FAILED

@moz-tools-bot
Copy link
Collaborator

moz-tools-bot commented Feb 9, 2026

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/1bdf305543a9a37/output.txt

Total script time: 47.29 mins

  • Integration Tests: FAILED

@calixteman calixteman merged commit 9870d89 into mozilla:master Feb 9, 2026
11 checks passed
@calixteman calixteman deleted the issue20629 branch February 9, 2026 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@timvandermeij timvandermeij timvandermeij approved these changes

Assignees

No one assigned

Labels

core

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: Regression: "Invalid page request" when rendering multiple documents concurrently in v5.4.624

3 participants

@calixteman @moz-tools-bot @timvandermeij