-
Notifications
You must be signed in to change notification settings - Fork 10.6k
Fix infinite loop in JBIG2 decoder with symbol dictionary context retention #20539
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -2819,6 +2819,13 @@ | |||||||||||||||||||
| "rounds": 1, | ||||||||||||||||||||
| "type": "eq" | ||||||||||||||||||||
| }, | ||||||||||||||||||||
| { | ||||||||||||||||||||
| "id": "issue20461", | ||||||||||||||||||||
| "file": "pdfs/bitmap-symbol-context-reuse.pdf", | ||||||||||||||||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Please note that this file is already checked in by now at pdf.js/test/test_manifest.json Lines 13502 to 13509 in 2b95a8e
pdf.js/test/test_manifest.json Line 13507 in 2b95a8e
eq.
The problem described above still stands though. |
||||||||||||||||||||
| "md5": "3d79e2d087515c2fdbed6fec0ad86e91", | ||||||||||||||||||||
| "rounds": 1, | ||||||||||||||||||||
| "type": "eq" | ||||||||||||||||||||
| }, | ||||||||||||||||||||
| { | ||||||||||||||||||||
| "id": "issue20439", | ||||||||||||||||||||
| "file": "pdfs/issue20439.pdf", | ||||||||||||||||||||
|
|
||||||||||||||||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I open the PDF file from this commit with the preview build at http://54.241.84.105:8877/070ff3f62b453a4/web/viewer.html there is no infinite loop anymore, but I also don't see any image rendering, and the console shows this:
That seems to relate to this line, so it looks like this may not actually work as expected?