This repository was archived by the owner on Nov 27, 2018. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This version only adds a new template for sw-precahe (avoiding the cache per resource approach of the original template). The main problem here is how to keep the two cache versions until activation has been done as sw-precache does not identify the new worker as it does
cacheVersionin pr #188.The proposal use a temporal new cache to populate it during installation. During activation, the contents of this new cache are moved to the current. Personally, I don't like this solution as if for some reason, the activation process gets interrupted, the contents can be lost or be only partially updated. This can not occur in pr #188.
Another problem is that we need to keep the hashes as part of the actual code (not commentaries as in pr #188) because we need to retain the fingerprint of the content being cache in order to produce a byte-level change when updating the resources. In the pr #188 this is addressed by including a hash of all content hashes.